Implement tmc2208 step+dir+step filter (TAKE 2) #2597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KevinOConnor
force-pushed
the
work-stepdirstep-20200306
branch
2 times, most recently
from
39351bb to
e3908a3
Compare
KevinOConnor
force-pushed
the
work-stepdirstep-20200306
branch
from
e3908a3 to
acd165c
Compare
|
This was merged as of commit acd165c. -Kevin |
This was referenced Mar 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a retry on PR #2565. To test this branch:
cd ~/klipper; git checkout origin/work-stepdirstep-20200306; sudo service klipper restartAs with PR #2565, this update is intended to improve support for tmc2208 drivers in stealhchop mode - even when they are in standalone mode. See the description of PR #2565 for more details.
This new version of the code should do a better job of flushing steps and thus avoid the "Timer too close" errors that the previous code could result in.
-Kevin