Updated CMakeLists.txt to enable installing on Windows#313
Closed
jjhegedus wants to merge 1 commit intoKjellKod:masterfrom
jjhegedus:master
Closed
Updated CMakeLists.txt to enable installing on Windows#313jjhegedus wants to merge 1 commit intoKjellKod:masterfrom jjhegedus:master
jjhegedus wants to merge 1 commit intoKjellKod:masterfrom
jjhegedus:master
Conversation
Owner
|
Another PR was opened that does the same think but with more extensive support for finding G3log on Windows. Please try it out. If it works out then I think you can close this one: #312 (review) |
Author
|
I tested #312 and it works for my use case. Closing this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, Kjell, I made a small modification to enable g3logger to be installed on windows. In order to avoid requiring it to be run as administrator, I used the following command to build.
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=c:/usr/local -DCMAKE_INSTALL_PREFIX=c:/usr/local ..
I didn't pass in a specific generator but let it select the currently installed Visual Studio.
I followed up with this command to build and install
cmake --build . --target INSTALL --config Debug
This successfully installed g3log under c:/usr/local. I used Debug on both of these to enable debugging from the Visual Studio IDE as I was developing. Obviously these could be replaced with Release for a Release build.
I recognize that I should create some tests and I'll be reading up on ctest, gtest and CI so I can get there but it may take a bit. I didn't make any updates to the README or API.markdown but I'll do that as well as I get tests set up.
I felt like I needed to do this to enable and guide the work I'm doing on g3sink/tracelogging, which I also have a cut of to submit momentarily but based on where this is currently, I'll understand if you reject the pull. If you accept or not, any suggestions on how to set up tests on Windows and how to set up Windows CI will be appreciated.
Jeff