COMP: Use modern macro for name of class#69
Merged
dzenanz merged 5 commits intoKitwareMedical:mainfrom Jan 27, 2025
Merged
Conversation
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
Contributor
Author
|
@dzenanz Part of slicer update preparations. |
1 similar comment
Contributor
Author
|
@dzenanz Part of slicer update preparations. |
Deprecated `itkTypeMacro` and `itkTypeMacroNoParent`, in favor of `itkOverrideGetNameOfClassMacro` and `itkVirtualGetNameOfClassMacro`, respectively.
12 tasks
Member
|
It looks like you need to apply clang-format. |
Contributor
Author
|
Should the new clang format be applied to Remote modules? |
Contributor
Author
|
@dzenanz FYI: I upgraded to match the tooling of ITK. |
311c945 to
16ab621
Compare
dzenanz
reviewed
Jan 27, 2025
Member
dzenanz
left a comment
There was a problem hiding this comment.
I think we need to bump this:
from 5.4 to master to make CI green.
Member
|
Perhaps after merging InsightSoftwareConsortium/ITKClangFormatLinterAction#7. |
Member
I tried to do this here, but there are errors: |
dzenanz
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON
The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro