COMP: Use modern macro for name of class

[hjmjohnson]

When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON

The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro

[hjmjohnson]

@dzenanz This is part of an effort to create a v5.4.2.1 release that allows Slicer to build with ITK_LEGACY_REMOVE and ITK_FUTURE_LEGACY_REMOVE turned on.

It is an intermediate refactoring that is upstream compatible but allows Slicer to catch up more slowly.

[hjmjohnson]

@dzenanz Part of the future updates needed to build Slicer with future code recommendationsl

[dzenanz]

This sounds like WASM part needs to be updated to use a newer base image:

In file included from /work/wasm/morphological-contour-interpolation.cxx:24:
/work/include/itkMorphologicalContourInterpolator.h:83:3: error: unknown type name 'itkOverrideGetNameOfClassMacro'
   83 |   itkOverrideGetNameOfClassMacro(MorphologicalContourInterpolator);
      |   ^
1 error generated.

[thewtex]

Is itkOverrideGetNameOfClassMacro in the release-5.4 branch?

[dzenanz]

Yes, it was added in Dec 2023.

[dzenanz]

It is there already in v5.4.0:
https://github.com/InsightSoftwareConsortium/ITK/blob/v5.4.0/Modules/Core/Common/include/itkMacro.h#L463

[thewtex]

I will rebase, follow-up.

[dzenanz]

Can you rebase this Hans?

[hjmjohnson]

@dzenanz Rebased.

[dzenanz]

Matt, would changes from InsightSoftwareConsortium/ITKMeshToPolyData#77 work here?

[thewtex]

Wasm updates for ITK 5.4.2 are here: #130