Fix windowing configuration precedence and DICOMs with no window level tags #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break down computeDefaultConfig into smaller functions to make the priority chain clearer (runtime config > DICOM > stats). Extract minMaxToWidthLevel utility to DRY up width/level calculation.
Adds test to verify that runtime config window/level values take precedence over DICOM metadata. Also adds waitForLoadingIndicator helper to page object and sets VITE_SHOW_SAMPLE_DATA=true for e2e tests.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Adds test for DICOM files without window/level metadata tags to ensure they use auto windowing based on image statistics (1900/1050 for minimal.dcm) instead of defaulting to incorrect values. Tests the fix from commit 3004b94.
PaulHax
force-pushed
the
fix-windowing
branch
from
9a49231 to
a3a6485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Tests:
waitForLoadingIndicatorhelper to page objectVITE_SHOW_SAMPLE_DATA=truefor e2e test commandsRefactor: