Fix non standard DICOM date tags #799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Patch itk-wasm to escape control characters (ASCII 0-31 except tab/LF/CR, plus DEL) in JSON strings before parsing. This fixes avoids this error `SyntaxError: Bad control character in string literal in JSON` The readImage GDCM reader reads these corrupt tags literally and serializes them to JSON without escaping, causing JSON.parse() to error.
PaulHax
force-pushed
the
dicom-bad-date-tags
branch
from
b8756ac to
859dadc
Compare
|
Can we just upstream this fix to the relevant itk-wasm libraries (given that we control them) and bump our dependency version? That seems preferable to patching, in terms of maintainability. |
|
Agreed. Starting that InsightSoftwareConsortium/ITK-Wasm#1454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing DICOM date tags in the wild that have control characters in some of their date VR tags. See attached DICOM file in the zip
corrupt_dates.zip
When loading this file in VolView we got an error calling
@itk-wasm/image-io::readImage:Now we are escaping these control characters via a patch.
In the future could fix
@itk-wasm/image-io::readImage's use of theglazeJSON library to use itsescape_control_charactersoption.