Fix Py 2 to 3 encoding errors #410
Conversation
|
This pull request introduces 1 alert when merging 13060fb into 9697837 - view on LGTM.com new alerts:
|
| @@ -181,11 +181,9 @@ def _setup_network(self): | |||
| # - ``caffe.TEST`` indicates phase of either TRAIN or TEST | |||
| self._log.debug("Initializing network") | |||
| self._log.debug("Loading Caffe network from network/model configs") | |||
| self.network = caffe.Net(self.network_prototxt.write_temp(), | |||
| self.network = caffe.Net(self.network_prototxt, | |||
There was a problem hiding this comment.
self.network_prototxt here, as well as self.network_model below, should be DataElement instances at this stage. I believe Caffe 1 wanted filepaths here, thus the previous write_temp() calls. Is this not the case any more? I realize that the caffe 1 generator might be getting a little stale at this point.
There was a problem hiding this comment.
It still seems to accept a string as input. I can change the documentation in Linehttps://github.com/Kitware/SMQTK/blob/654f69e0db89ce7b0a2fd13b27ef503ed4523e6b/python/smqtk/algorithms/descriptor_generator/caffe_descriptor.py#L58 to string and the setstate function to reflect the same. Please let me know if you think that sounds right.
This merges changes made to path encodings in Caffe descriptor generator and fixed error during file upload.