Support latest version on numpy in pickle operation #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought this was originally not required for this as I thought that saving the tuple-cast version of the set would use numpy format. Turns out though that when using large integers, e.g. 256-bit ints (because hash codes), numpy can't use one of its built-in types to cast to so it creates an array whose values are of python-object type. Then, because this isn't a numpy type, numpy cascades into using pickle to serialize the array components. Thus allow_pickle is required on load of that array due to the default change in numpy. |
|
@mattdawkins Is there bandwidth to add a unit test for this as well as adding a change-note? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.