Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to limit ITQ training memory usage #373

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

predicative
Copy link
Contributor

This is #370 again, but this time against master.

Copying from there:

This PR adds the ability to limit memory usage [during] ITQ training. The current implementation modifies the train_itq.py tool to have an option max_descriptors that, when set and if necessary, sub-samples the available descriptors to the desired amount.

... [snip] ...

I'll also note that there may be some other opportunities to save memory (namely by del'ing descriptors in ItqFunctor.fit after its last use; see below), but this seems like good functionality to have anyway.

x = elements_to_matrix(descriptors, report_interval=dbg_report_interval,

I've combined the commits from #370 into one and added a release note.

@Purg, would you be interested in seeing tests for this, and if so, could you advise on how best to do so? My initial idea would involve a rather large amount of mocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant