New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepopulated descriptor generator #41

Merged

Purg merged 1 commit into Kitware:master from pbeasly:dev/prepopulated_descr_generator

Jun 10, 2024

Contributor

pbeasly commented May 20, 2024 •

edited

Loading

Add a module/ class for a PrePopulatedDescriptorGenerator to use when descriptors are already generated and prepopulated into a descriptor set.

modified pyproject.toml to add the new descriptor generator module.
created prepopulated implementation of descriptor generator and the class PrepopulatedDescriptorGenerator.
created an in-progress test_prepopulated.py file

Purg requested changes

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Show resolved Hide resolved

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Erotemic reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Erotemic reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Erotemic reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Erotemic reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Erotemic reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

smqtk_descriptors/impls/descriptor_generator/prepopulated.py Outdated Show resolved Hide resolved

pbeasly force-pushed the dev/prepopulated_descr_generator branch from a2a8669 to d4701df Compare

May 21, 2024 18:52

Purg reviewed

View reviewed changes

tests/impls/descriptor_generator/test_prepopulated.py Outdated Show resolved Hide resolved

pbeasly marked this pull request as draft

May 22, 2024 13:13

pbeasly marked this pull request as ready for review

June 2, 2024 02:04

Erotemic reviewed

View reviewed changes

tests/impls/descriptor_generator/test_prepopulated.py Outdated Show resolved Hide resolved

pbeasly force-pushed the dev/prepopulated_descr_generator branch 2 times, most recently from 4393e7f to 39ed7d5 Compare

June 7, 2024 13:10


          Create prepopulated descriptor generator module and class

32abcbd

pbeasly force-pushed the dev/prepopulated_descr_generator branch from 39ed7d5 to 32abcbd Compare

June 10, 2024 16:14

Member

Erotemic commented Jun 10, 2024

LGTM, @Purg any issues with merging this?

Purg approved these changes

View reviewed changes

Purg merged commit 0130332 into Kitware:master

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet