Merge pull request #42 from Erotemic/dev/fix-rtd

Fix RTD for 2024 services
Kitware · May 21, 2024 · c52b243 · c52b243
2 parents 68a66ea + aa8858b
commit c52b243
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/.github/workflows/ci-unittests.yml b/.github/workflows/ci-unittests.yml
@@ -127,9 +127,13 @@ jobs:
         run: poetry run pytest
 
       - name: CodeCov report submission
-        if: ${{ github.event_name != 'schedule' }}
-        uses: codecov/codecov-action@v3
+        # Only upload coverage if we have the token
+        env:
+          HAVE_CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN != '' }}
+        if: ${{ github.event_name != 'schedule' && env.HAVE_CODECOV_TOKEN == 'true' }}
+        uses: codecov/[email protected]
         with:
           fail_ci_if_error: true
           files: coverage.xml
           flags: unittests
+          token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.readthedocs.yaml b/.readthedocs.yaml
@@ -1,8 +1,11 @@
 version: 2
 formats:
   - pdf
+build:
+  os: "ubuntu-22.04"
+  tools:
+    python: "3.8"
 python:
-  version: 3.8
   install:
     - requirements: docs/readthedocs-reqs.txt
     - method: pip

diff --git a/docs/readthedocs-reqs.txt b/docs/readthedocs-reqs.txt
@@ -1,3 +1,5 @@
+Sphinx >= 3.5.3
+sphinx-rtd-theme >= 0.5.1
 # Additional requirements for building our documentation in RTD
 sphinx-argparse==0.2.5
 sphinx-prompt==1.4.0
diff --git a/docs/release_notes/pending_release.rst b/docs/release_notes/pending_release.rst
@@ -6,3 +6,5 @@ Updates / New Features
 
 Fixes
 -----
+
+* Fixes for CI and readthedocs