Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension template and feature enhacements #46

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

sadhana-r
Copy link
Collaborator

@sadhana-r sadhana-r commented Jan 9, 2025

This PR includes the following changes:

  • Updates the Bone Texture extension to utilize parameter nodes
  • Combines the serialize mode features within the main extension (and removes the separate serializer module)
  • Fixes bugs in the bone texture computation
  • Removes the option to save texture colormaps as CSV files. Is that option needed?
  • Allows user to specify the csv filename when saving computed features.
  • Adds the ability to compute textures across an entire image (without a segmentation mask)

@sadhana-r sadhana-r force-pushed the update_extension_parameter_nodes branch from 2cab040 to b0d5517 Compare February 11, 2025 19:39
@sadhana-r sadhana-r marked this pull request as ready for review February 11, 2025 19:40
@sadhana-r sadhana-r requested a review from bpaniagua February 11, 2025 19:47
@bpaniagua
Copy link
Collaborator

A few notes:

  • Simplify extension and reduce redundancy by adding serializing features to Bone Texture. Include an option in the input menu that allow to choose if you are running for a single scan or a collection of scans (after parsing a directory).
  • Add export menu to Bone Texture module. It would be great to have the "separate feature maps" as part of the Bone Texture extension, right now they are part of the serializer only.

Copy link
Collaborator

@bpaniagua bpaniagua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants