Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds username AUTH, disconnect methods. #84

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds username AUTH, disconnect methods. #84

wants to merge 5 commits into from

Conversation

scuml
Copy link
Contributor

@scuml scuml commented Oct 14, 2020

  • Adds AUTH with username support
  • Adds redis.disconnect()

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mbarnach
mbarnach requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could add a test of the new function, it would be nice.
Could you explain why you change the visibility of the RedisResp class, even if nothing is public inside?

Sources/SwiftRedis/Redis.swift Outdated Show resolved Hide resolved
Sources/SwiftRedis/RedisResp.swift Show resolved Hide resolved
Sources/SwiftRedis/RedisResp.swift Outdated Show resolved Hide resolved
Sources/SwiftRedis/Redis.swift Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scuml scuml requested a review from mbarnach November 16, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarnach mbarnach Awaiting requested review from mbarnach

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scuml @mbarnach