This is a fix for colons in the password of a HTTP Basic Authentication. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code was taking the first component of the colon-separated array as the user name, and the second as the password. In fact, all components after the first must be treated as belonging to the password, and joined together with a colon separator. Fix for Kitura#54
|
|
|
Thanks for the PR! I think it might be worth reworking this code to use https://developer.apple.com/documentation/swift/string/2894564-split instead of |
…plit instead of String.components
|
Fix looks good to me! Are you happy @Andrew-Lees11 ? |
|
This looks good to me as well. |
Andrew-Lees11
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code was taking the first component of the colon-separated array as the user name,
and the second as the password. In fact, all components after the first must be treated as belonging
to the password, and joined together with a colon separator.
Fix for #54