Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update credentials package #47

Merged
merged 1 commit into from
Mar 14, 2018
Merged

update credentials package #47

merged 1 commit into from
Mar 14, 2018

Conversation

Andrew-Lees11
Copy link
Contributor

Update Kitura-Credentials.git dependency to take up to next major so that it works with Kitura-Credentials 2.1.0 (and hence kitura 2.2.0) and gives us more flexibility in our dependencies.

@codecov-io
Copy link

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files           2        2           
  Lines         167      167           
=======================================
  Hits          134      134           
  Misses         33       33
Flag Coverage Δ
#CredentialsHTTP 80.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568bc0a...abc36a5. Read the comment docs.

Copy link
Collaborator

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but would like @djones6's views too.

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is okay.

This change allows Kitura-CredentialsHTTP to build alongside Kitura 2.1 and 2.2, as it can access the latest minor of Kitura-Credentials which bumps the Kitura-Session dependency to 3.0.

My only concern would be whether SPM resolves an existing Kitura 2.0 project in a reasonable amount of time - ie. whether the fact that it will need to roll back Kitura-Credentials to 2.0 is a problem. There is a solution, so one would hope so.

I'd suggest once this is merged and tagged, testing a kitura init project with Kitura-CredentialsHTTP included and the Kitura dependency set to .upToNextMinor(from: "2.0.0"), to make sure it resolves.

@ianpartridge
Copy link
Collaborator

Thanks @djones6. I'm going to merge this. @Andrew-Lees11 can you tag a patch release and then immediately do the testing @djones6 suggests?

@ianpartridge ianpartridge merged commit 953c618 into master Mar 14, 2018
@ianpartridge ianpartridge deleted the updatePackage branch March 14, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants