Issue.516 removing SwiftyJSON #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunniclm
approved these changes
Jan 11, 2018
|
Approved conditional on the necessary |
tunniclm
reviewed
Jan 24, 2018
Package.swift
Outdated
| @@ -29,7 +29,7 @@ let package = Package( | |||
| ) | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", .upToNextMinor(from: "2.0.0")), | |||
| .package(url: "https://github.com/IBM-Swift/Kitura-Credentials.git", from: "2.0.0"), | |||
There was a problem hiding this comment.
Let's make this .upToNextMinor(from: "2.1.0") so that we can tag Kitura-Credentials as 2.1.0 instead of being forced to tag it 3.0.0 (since it removes SwiftyJSON which this package is relying on indirectly). Keeping the version range to minors will mean we have a bit more maintenance to do keeping the Package.swift up to date, but hopefully it will reduce the likelihood of slow/hang resolution problems with SPM.
tunniclm
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependancy on swiftyJSON for issue #516 so that Kitura-CredentialsGitHub
will work with the updated Kitura-Sessions