-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different delegate methods for each Credentials plugin #42
Comments
These are not the same options. There are two kinds of options:
|
Thanks for your response. I'm not using the CredentialsGoogle plugin, I'm using the CredentialsGoogleToken plugin. I do not see an options parameter for that constructor. It seems that CredentialsGoogleToken takes its options only from the Credentials object. |
You are right, but I think a better way to fix this is to add options to CredentialsGoogleToken constructor similar to CredentialsGoogle. |
👍 |
* Kitura/Kitura-Credentials#42 Pass options to the constructor * Kitura/Kitura-Credentials#42 Update documentation * IBM-Swift/Kitura-Crdedentials#42 Keep the current API - look for options in authenticate() argument if not set in init()
* Kitura/Kitura-Credentials#42 Pass options to the constructor * Kitura/Kitura-Credentials#42 Update documentation * IBM-Swift/Kitura-Crdedentials#42 Keep the current API - look for options in authenticate() argument if not set in init()
@crspybits Could you please verify that the problem is solved now? |
For the Google credentials, the CredentialsGoogleOptions.userProfileDelegate is currently defined as
However, since the options seems scoped across all plugins (i.e., in the options property of a Credentials object), could CredentialsGoogleOptions.userProfileDelegate be defined as:
public static let userProfileDelegate = "googleUserProfileDelegate" ?
The text was updated successfully, but these errors were encountered: