Convert bytes directly to Data instead of UnsafePointer API

[jayrhynas]

Description

Replaces an incorrect use of UnsafePointer<UInt8>(array) to initialize Data.
There is already a Data(_ elements: Sequence<UInt8>) initializer we can use directly.

Motivation and Context

Using a pointer to an array created via the UnsafePointer initializer is undefined and isn't guaranteed to be valid. In particular, we ran into this issue when our RSA key started failing on iOS 18 release builds. The data in strippedKeyBytes was valid on the line above, but data was all zeroes after being initialized with UnsafePointer.

BlueRSA/Sources/CryptorRSA/CryptorRSAUtilities.swift

Lines 288 to 290 in 440f78d

	let strippedKeyBytes = [UInt8](byteArray[index...keyData.count - 1])
	let data = Data(bytes: UnsafePointer<UInt8>(strippedKeyBytes), count: keyData.count - index)
	return data

As stated in the "Important" note in the UnsafePointer documentation:

The pointer created through implicit bridging of an instance or of an array’s elements is only valid during the execution of the called function. Escaping the pointer to use after the execution of the function is undefined behavior. In particular, do not use implicit bridging when calling an UnsafePointer initializer.

How Has This Been Tested?

I ran the existing test suite in Release mode. Before the fix there were 16/32 passes, after the fix there are 32/32 passes.

This was tested with Xcode 16.0 (16A242d).
Devices:

• iPhone 13 Pro running iOS 18.0 (22A3354)
• MacBook Pro 14", 2021 running macOS 14.6.1 (23G93)

[CLAassistant]

All committers have signed the CLA.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[yoller]

Good improvement. Replacing UnsafePointer with Data(strippedKeyBytes) enhances memory safety and avoids potential deallocation issues. This change also resolves the problem encountered on iOS 18, where using UnsafePointer caused the data to be zeroed out despite being valid in strippedKeyBytes.

[euronovate-dev]

Tested that this change resolves the issue encountered on iOS 18

[Joebayld]

This is the solution to #84

Can this get merged? The library currently does not work in Release mode on macOS 15.

[dannys42]

Thank you @jayrhynas for the fix and detailed description.