Update to use SecKeyCreateRandomKey to generate key pairs #78

LowAmmo · 2022-09-30T18:13:59Z

SecKeyGeneratePair was deprecated with iOS 15

Upgraded to support building with Xcode 14 - with no warnings

Updated minimum supported versions -

MacOS - 11.5
iOS - 14.5
TVOS - 14.5
WatchOS - 7.5

Testing

Converted to use xctestplans
Added support to do iOS testing
- Had to add compiler flags to enable successful testing on a simulator

Updating to switch from the deprecated SecKeyGeneratePair to SecKeyCreateRandomKey

Description

SecKeyCreateRandomKey

Removed use of the SecKeyGeneratePair API (that was deprecated with iOS 15.0) to now use the SecKeyCreateRandomKey

Minimum Versions

Updated the minimum OS Versions to more recent versions to address additional build warnings

Unit Testing

Added a test target to run unit tests on an iOS device
As part of this, had to use some compiler directives to support successfully running tests on the simulator
Also converted to using xctestplans - as that is the new standard for Xcode

Motivation and Context

It was done to eliminate warnings that we see in our application, and also to just update the repo to more recent standards

Issue: #77

How Has This Been Tested?

Tested locally by confirming successful unit tests.
Also tested in our application to verify change was passive

Checklist:

If applicable, I have updated the documentation accordingly.
If applicable, I have added tests to cover my changes.

SecKeyGeneratePair was deprecated with iOS 15 Upgraded to support building with Xcode 14 - with no warnings Updated minimum supported versions - * MacOS - 11.5 * iOS - 14.5 * TVOS - 14.5 * WatchOS - 7.5 Testing * Converted to use xctestplans * Added support to do iOS testing * Had to add compiler flags to enable successful testing on a simulator

CLAassistant · 2022-09-30T18:14:04Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LowAmmo
❌ Kris Kline

Kris Kline seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dannys42

Thanks for the PR! If there's any way you can exclude formatting changes, it would make it easier to evaluate.

Sources/CryptorRSA/CryptorRSAKey.swift

dannys42 · 2022-10-02T05:21:51Z

BlueRSA.podspec

-s.osx.deployment_target = "10.12"
-s.ios.deployment_target = "10.3"
-s.tvos.deployment_target = "10.3"
-s.watchos.deployment_target = "3.3"
+s.osx.deployment_target = "11.5"
+s.ios.deployment_target = "14.5"
+s.tvos.deployment_target = "14.5"
+s.watchos.deployment_target = "7.5"


Thanks for checking the deployment targets! Just wanted to confirm if these are the minimum versions that will work with these changes?

If it's a concern...can get away with going with even older versions...

I've just gotten in the habit with Apple of trying to stay as up to date as possible.

dannys42 · 2022-10-02T05:22:24Z

CryptorRSA.xcodeproj/xcshareddata/xcschemes/CryptorRSA-iOS.xcscheme

+      <TestPlans>
+         <TestPlanReference
+            reference = "container:Tests/CryptorRSA-iOSTests/CryptorRSA-iOSTests.xctestplan"
+            default = "YES">
+         </TestPlanReference>
+      </TestPlans>


I must admit I have not yet used TestPlans, but they look really useful! How can I trigger them? I can't seem to find a way to exercise them.

When using the .xcodeproj it ties into the scheme. In the scheme 'Test' step, you can choose what "test plan" to run (instead of choosing what test target to run).

One of my favorite features is the "random" order - it just helps to pinpoint any tests that accidentally have a dependency on run order (very helpful if you have multiple people contributing to the same repo).

Otherwise, they just help keep things a little bit cleaner (I wonder if Apple's long term plan is to eliminate to the need to have a Test target as part of the project build??)

README.md

dannys42 · 2022-10-02T05:24:28Z

Sources/CryptorRSA/CryptorRSAKey.swift

+		let parameters: [NSObject: Any] = [
+			kSecAttrKeyType: kSecAttrKeyTypeRSA,
+			kSecAttrKeySizeInBits: keySize.bits,
+            kSecPublicKeyAttrs: publicKeyAttributes,
+            kSecPrivateKeyAttrs: privateKeyAbbributes,


spacing doesn't appear uniform here.

Guessing some got tabs & some got spaces...

I'll work to convert everything to use tabs

Tests/CryptorRSATests/CryptorRSATests.swift

LowAmmo · 2022-10-03T15:33:12Z

@dannys42 - Took a few commits to get the compiler directives right... But, I think the spacing is all good now! 😄

LowAmmo · 2023-02-28T18:26:02Z

@dannys42 - Did similar clean up to remove the generated files and just rely on Package.swift

sonarqubecloud · 2023-03-29T00:54:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

LowAmmo · 2023-03-29T16:30:57Z

@dannys42 - cleaned up the build to only build on valid/more recent build machines (to match the updates to the podspecs).

Seeing the odd issue where it suddenly has trouble connecting to the travis CI...but...hoping you might be able to get this (and other PRs merged in sometime soon...)

-Thanks!

sonarqubecloud · 2024-11-18T20:47:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

LowAmmo · 2024-11-18T20:48:14Z

@jayrhynas , @dannys42 - Any chance this could get reviewed and pulled?

jayrhynas · 2024-11-18T21:26:38Z

@jayrhynas , @dannys42 - Any chance this could get reviewed and pulled?

Just FYI I'm not a maintainer of this project, I just contributed once :)

LowAmmo · 2024-11-19T16:10:50Z

@dannys42 - Not sure if this counts as "looking a gift horse in the mouth"...but any chance you could also do an updated publish to the cocoapod spec repo? 😃

dannys42 · 2024-11-20T04:25:03Z

@LowAmmo I'm happy to add you as the cocoapods maintainer if you would like to manage it for the Kitura repos. Last time I dealt with cocoapods, there was just too many issues with downtime. Also the update process is a bit too cumbersome for me.

LowAmmo · 2024-11-20T15:16:16Z

@dannys42 - Sure! I know everything is moving to SPM...but our internal build system isn't ready to switch over just yet, so being able to just keep cocoapods up-to-date would be much appreciated!

Let me know what you need from me to get that setup!

-Thanks!

giovannitrezzi · 2024-11-21T11:52:18Z

We’re also awaiting the updated publish to the CocoaPod spec repo and look forward to its completion.
Thank you very much for your efforts and support!

giovannitrezzi · 2025-01-28T09:08:13Z

Hi @dannys42 and @LowAmmo,
Just checking in on the status of the CocoaPods spec repo update. Are there any updates or progress to share?

Thank you for your efforts

Kris Kline added 2 commits September 30, 2022 12:55

Update Readme.md

3541d98

dannys42 reviewed Oct 2, 2022

View reviewed changes

Kris Kline added 4 commits October 3, 2022 10:25

Replace (4 spaces) with \t (tab)

80a6883

match old indenting for compiler directives

1b64565

Turns out these had spaces before...

f4f3f2f

another try on proper spacing...

4ffdb26

Remove unnecessary generated files

f0e35a2

LowAmmo added 4 commits March 28, 2023 16:28

Update .travis.yml to more recent build box versions

894f928

Trim travis.yml a little more

926750b

new line to trigger new build

5129a2d

revert back

6946ec0

Merge branch 'master' into Issue77-SecKeyCreateRandomKey

aff475f

dannys42 merged commit a03491f into Kitura:master Nov 19, 2024
1 of 2 checks passed

LowAmmo deleted the Issue77-SecKeyCreateRandomKey branch November 20, 2024 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to use SecKeyCreateRandomKey to generate key pairs #78

Update to use SecKeyCreateRandomKey to generate key pairs #78

LowAmmo commented Sep 30, 2022

CLAassistant commented Sep 30, 2022 •

edited

Loading

dannys42 left a comment

dannys42 Oct 2, 2022

LowAmmo Oct 3, 2022

dannys42 Oct 2, 2022

LowAmmo Oct 3, 2022

dannys42 Oct 2, 2022

LowAmmo Oct 3, 2022

LowAmmo commented Oct 3, 2022

LowAmmo commented Feb 28, 2023

sonarqubecloud bot commented Mar 29, 2023

LowAmmo commented Mar 29, 2023

sonarqubecloud bot commented Nov 18, 2024

LowAmmo commented Nov 18, 2024

jayrhynas commented Nov 18, 2024

LowAmmo commented Nov 19, 2024

dannys42 commented Nov 20, 2024

LowAmmo commented Nov 20, 2024

giovannitrezzi commented Nov 21, 2024 •

edited

Loading

giovannitrezzi commented Jan 28, 2025

Update to use SecKeyCreateRandomKey to generate key pairs #78

Update to use SecKeyCreateRandomKey to generate key pairs #78

Conversation

LowAmmo commented Sep 30, 2022

Description

Motivation and Context

How Has This Been Tested?

Checklist:

CLAassistant commented Sep 30, 2022 • edited Loading

dannys42 left a comment

Choose a reason for hiding this comment

dannys42 Oct 2, 2022

Choose a reason for hiding this comment

LowAmmo Oct 3, 2022

Choose a reason for hiding this comment

dannys42 Oct 2, 2022

Choose a reason for hiding this comment

LowAmmo Oct 3, 2022

Choose a reason for hiding this comment

dannys42 Oct 2, 2022

Choose a reason for hiding this comment

LowAmmo Oct 3, 2022

Choose a reason for hiding this comment

LowAmmo commented Oct 3, 2022

LowAmmo commented Feb 28, 2023

sonarqubecloud bot commented Mar 29, 2023

LowAmmo commented Mar 29, 2023

sonarqubecloud bot commented Nov 18, 2024

Quality Gate passed

LowAmmo commented Nov 18, 2024

jayrhynas commented Nov 18, 2024

LowAmmo commented Nov 19, 2024

dannys42 commented Nov 20, 2024

LowAmmo commented Nov 20, 2024

giovannitrezzi commented Nov 21, 2024 • edited Loading

giovannitrezzi commented Jan 28, 2025

CLAassistant commented Sep 30, 2022 •

edited

Loading

giovannitrezzi commented Nov 21, 2024 •

edited

Loading