Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 5 #45

Merged
merged 6 commits into from
Apr 11, 2019
Merged

Support Swift 5 #45

merged 6 commits into from
Apr 11, 2019

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Apr 4, 2019

Update to Swift 5, and use official Docker images for CI.

TODO: resolve Swift 5 warnings related to Data.withUnsafeBytes changes and Data.init(bytes:) -> Data.init(_:) - for reference, similar changes were required in Kitura/BlueSocket#170 and Kitura/Kitura-net#297

@djones6 djones6 added this to the 2019.07 milestone Apr 4, 2019
@Andrew-Lees11 Andrew-Lees11 changed the title [WIP] Support Swift 5 Support Swift 5 Apr 9, 2019
@Andrew-Lees11 Andrew-Lees11 requested a review from billabt April 9, 2019 09:43
@Andrew-Lees11 Andrew-Lees11 modified the milestones: 2019.07, 2019.08 Apr 10, 2019
Copy link
Collaborator

@billabt billabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@billabt billabt merged commit 1c43d6f into master Apr 11, 2019
@djones6 djones6 deleted the swift5 branch April 29, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants