Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 4.2 #25

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Support Swift 4.2 #25

merged 3 commits into from
Oct 2, 2018

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Oct 2, 2018

Description

Updates for Swift 4.2 to resolve compilation warnings. Specifically:

  • Updates .swift-version to 4.2 and adjusts .travis.yml accordingly,
  • Reorganizes the Package.swift files:
    • Removes a redundant Package.swift, and renames the 4.2-compatible [email protected] to Package.swift,
    • Updates Package.swift to Swift 4.2 format (// swift-tools-version:4.2) so that we build in 'full' 4.2 mode,
    • Renames the [email protected] -> [email protected] (SPM otherwise does not pick these up)
  • Updates the Swift 4.2 package to use version 2.0 of the OpenSSL dependency, which has been restructured into Swift 4.2 format,
  • Adds a missing dependency declaration for OpenSSL to the CryptorRSA target to eliminate a warning (I'm surprised this compiled before).

I noted that there is another compile warning relating to returning a force-unwrapped type. I did not attempt to address this as part of this PR.

Motivation and Context

Resolves compiler warnings relating to the use of system packages with Swift 4.2.
(see: https://github.com/apple/swift-evolution/blob/master/proposals/0208-package-manager-system-library-targets.md)

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@djones6 djones6 changed the title [WIP] Support Swift 4.2 Support Swift 4.2 Oct 2, 2018
@billabt billabt merged commit ed67d18 into master Oct 2, 2018
@djones6 djones6 deleted the swift42 branch October 2, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants