Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates for Swift 4.2 to resolve compilation warnings. Specifically:
.swift-version
to 4.2 and adjusts.travis.yml
accordingly,Package.swift
, and renames the 4.2-compatible[email protected]
toPackage.swift
,Package.swift
to Swift 4.2 format (// swift-tools-version:4.2
) so that we build in 'full' 4.2 mode,[email protected]
->[email protected]
(SPM otherwise does not pick these up)2.0
of the OpenSSL dependency, which has been restructured into Swift 4.2 format,I noted that there is another compile warning relating to returning a force-unwrapped type. I did not attempt to address this as part of this PR.
Motivation and Context
Resolves compiler warnings relating to the use of system packages with Swift 4.2.
(see: https://github.com/apple/swift-evolution/blob/master/proposals/0208-package-manager-system-library-targets.md)
How Has This Been Tested?
Checklist: