Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RSA Signing to add padding option, and use correct function to get sig size #11

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Update RSA Signing to add padding option, and use correct function to get sig size #11

merged 1 commit into from
Jan 12, 2018

Conversation

gtaban
Copy link
Contributor

@gtaban gtaban commented Jan 3, 2018

For Signing:

  • Use DigestSignFinal to get the actual size of the signature
    For Signing/Verifying:
  • Use pkey context to add the padding option

Also correct some error messages.

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@gtaban
For Signing:
abad813 
- Use DigestSignFinal to get the actual size of the signature
For Signing/Verifying:
- Use pkey context to add the padding option
@gtaban
Copy link
Contributor Author

gtaban commented Jan 11, 2018

Hi @billabt , can you review this so it can be merged? thx

@billabt billabt merged commit fdbb74f into Kitura:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtaban @billabt