Source range for pipe value used as unlabelled arg#6787
Merged
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #6787 will not alter performanceComparing Summary
|
jtran
approved these changes
May 9, 2025
Contributor
jtran
left a comment
jtran
left a comment
There was a problem hiding this comment.
Looks good. One suggestion, if you like.
| .clone() | ||
| .map(|val| Arg::new(val, pipe_value_source_range)); | ||
| let Some(unlabeled) = args.unlabeled.take().or(default_unlabeled) else { | ||
| let unlabelled = args.kw_args.unlabeled.take().or_else(|| args.pipe_value.take()); |
Contributor
There was a problem hiding this comment.
We already have Args::unlabeled_kw_arg_unconverted() that computes the unlabeled arg from all its possible inputs. To reduce duplication, or at least keep it together, could we maybe make another flavored function over there in Args that takes ownership, instead of reaching into it from here?
adamchalmers
approved these changes
May 9, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6613
Extracted from #6644 to just fix the source range without touching the kwarg shorthand (left for post 1.0).