Extend point-and-click edit flow to non-pipe Chamfer and Fillet#6767
Merged
Extend point-and-click edit flow to non-pipe Chamfer and Fillet#6767
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
pierremtb
reviewed
May 8, 2025
pierremtb
requested changes
May 8, 2025
Contributor
pierremtb
left a comment
pierremtb
left a comment
There was a problem hiding this comment.
Hell yeah, feels really good to be editing the three Fillet operations in the current onboarding bracket!!
Just a few things so we can bublle up the errors appropriately. There's an issue about doing that at #6514 for all commands, I'm trying to push a little bit on every edit :)
pierre edits Co-authored-by: Pierre Jacquier <pierrejacquier39@gmail.com>
…om/KittyCAD/modeling-app into max-extend-fillet-edit-to-non-pipe
pierremtb
approved these changes
May 8, 2025
pierremtb
reviewed
May 8, 2025
Contributor
pierremtb
left a comment
pierremtb
left a comment
There was a problem hiding this comment.
Thanks for the updates!
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6119
Related PR: #5946, #6437
Description:
The edit flow now updates the existing expression instead of deleting and recreating it. This change allows us to:
Side-edit:
Refactor the existing
modifyAstWithEdgeTreatmentAndTagfunction for a more cohesive behavior with theeditEdgeTreatmentflow in themodelingMachine.