Skip to content

Comments

Kurt composite attempt#6722

Merged
Irev-Dev merged 6 commits intokurt-bool-sketchonface-6307from
kurt-composite-attempt
May 6, 2025
Merged

Kurt composite attempt#6722
Irev-Dev merged 6 commits intokurt-bool-sketchonface-6307from
kurt-composite-attempt

Conversation

@Irev-Dev
Copy link
Contributor

@Irev-Dev Irev-Dev commented May 6, 2025

No description provided.

@qa-wolf
Copy link

qa-wolf bot commented May 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 7:45pm

@Irev-Dev Irev-Dev merged commit 614bfe7 into kurt-bool-sketchonface-6307 May 6, 2025
27 checks passed
@Irev-Dev Irev-Dev deleted the kurt-composite-attempt branch May 6, 2025 19:45
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Instrumentation Performance Report

Merging #6722 will not alter performance

Comparing kurt-composite-attempt (0a37e81) with main (1841e63)

Summary

✅ 54 untouched benchmarks

Irev-Dev added a commit that referenced this pull request May 6, 2025
* fix bool sketchOnFace

* fix chamfer test

* add test

* Kurt composite attempt (#6722)

* composite attempt

* Add forward edge to CSG artifacts in artifact graph

* Fix comment

* Move the doc comments above the attributes

* Fix to update the correct field of Path

* Update output

---------

Co-authored-by: Jonathan Tran <jonnytran@gmail.com>

* use rust defined composite solid edges instead

* Update src/hooks/useEngineConnectionSubscriptions.ts

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Revert PNG screenshots

* Fix TS formatting

---------

Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants