Fix resetting onboarding from settings in web after #6564#6675
Merged
franknoirot merged 1 commit intomainfrom May 2, 2025
Merged
Fix resetting onboarding from settings in web after #6564#6675franknoirot merged 1 commit intomainfrom
franknoirot merged 1 commit intomainfrom
Conversation
Oversight on my part while refactoring the onboarding system in #6564. The new centralized `acceptOnboarding` workflow constructs a relative path, so we have to get out of the settings before invoking it.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
changed the title
pierremtb
approved these changes
May 2, 2025
franknoirot
deleted the
franknoirot/adhoc/optional-onboarding-web-follow-up
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oversight on my part while refactoring the onboarding system in #6564. The new centralized
acceptOnboardingworkflow constructs a relative path, so we have to get out of the settings before invoking it.