Enable Boolean op deletion from the feature tree #6637
Conversation
Fixes #6584. Works locally but the new tests don't appear to work yet
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| selection.artifact && | ||
| selection.artifact.type !== 'sweep' && | ||
| selection.artifact.type !== 'plane' && | ||
| selection.artifact.type !== 'compositeSolid' && |
There was a problem hiding this comment.
@Irev-Dev I just added to the existing codepath here for point and click var declarations 🤷
| await test.step(`Delete ${operationName} operation via feature tree selection`, async () => { | ||
| await toolbar.openPane('feature-tree') | ||
| const ftOp = await toolbar.getFeatureTreeOperation(operationName, 0) | ||
| await ftOp.click({ button: 'left' }) | ||
| await page.keyboard.press('Delete') | ||
| await scene.settled(cmdBar) | ||
| await toolbar.closePane('feature-tree') | ||
|
|
||
| // Expect changes in ft and code | ||
| await toolbar.openPane('code') | ||
| await editor.expectEditor.not.toContain(operation.code) | ||
| await expect( | ||
| await toolbar.getFeatureTreeOperation(operationName, 0) | ||
| ).not.toBeVisible() | ||
| }) |
There was a problem hiding this comment.
Somehow this wasn't working well locally
There was a problem hiding this comment.
Which line was failing? I'm guessing this one?
await editor.expectEditor.not.toContain(operation.code)There was a problem hiding this comment.
It just doesn't delete in the test, so weird. Working on it now
There was a problem hiding this comment.
Went with right click -> Delete and that seems much better
There was a problem hiding this comment.
Or is it possible that execution and population of the feature tree were taking longer than the test could allow?
There was a problem hiding this comment.
I also added scene.settled, should be better I think!
pierremtb
changed the title
franknoirot
left a comment
franknoirot
left a comment
There was a problem hiding this comment.
I confirmed using the sample code from #6584 on a local build that this fixes the issue. Thanks!
pierremtb
deleted the
pierremtb/issue6584-Cant-Delete-Union-From-Feature-Tree
branch
Fixes #6584.
Works locally but the new tests don't appear to work yet