6458 Browser text-to-CAD should overwrite project and zoom to fit new model#6626
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@franknoirot @Irev-Dev this is the new button for text-to-CAD in the browser: I'm thinking if it's still useful to keep the existing content and append it with the newly generated model..should we have a second button for that or that would make the UI too crammed? There is a separate "Modify With Zoo Text-To-CAD" option that can be used for updating the existing model so maybe that's enough, but I imagine that can change the existing model unexpectedly, so it's not guaranteed it will just append a new model even if the user asks something like "add a new model to the existing one that looks like this: etc..." On desktop this is not an issue I think because a new file is generated so it can be used flexibly by import. |
I don't think we should do that because Text-to-CAD is run in such a way that we know it won't return failing KCL, but we have no way of knowing if the user's existing KCL in the file will collide or otherwise break the new Text-to-CAD-generated KCL appended after it; for example, if there are parameter names that collide. |
franknoirot
left a comment
franknoirot
left a comment
There was a problem hiding this comment.
Nice. I don't think you'll be able to have a web E2E test yet, but you can make an issue for it like #6611
andrewvarga
changed the title
2 participants
zoom_to_fitfrom 6442 "Zoom to fit" when kcl file is shared on web #6619test incoming: web tests are not working in CI yet