Skip to content

Revert "Make onboarding optional, able to be ignored on desktop" #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franknoirot merged 1 commit into from
May 1, 2025
Merged

Revert "Make onboarding optional, able to be ignored on desktop" #6610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions e2e/playwright/fixtures/homePageFixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export class HomePageFixture {
projectTextName!: Locator
sortByDateBtn!: Locator
sortByNameBtn!: Locator
tutorialBtn!: Locator

constructor(page: Page) {
this.page = page
Expand All @@ -44,7 +43,6 @@ export class HomePageFixture {

this.sortByDateBtn = this.page.getByTestId('home-sort-by-modified')
this.sortByNameBtn = this.page.getByTestId('home-sort-by-name')
this.tutorialBtn = this.page.getByTestId('home-tutorial-button')
}

private _serialiseSortBy = async (): Promise<
Expand Down
4 changes: 0 additions & 4 deletions e2e/playwright/fixtures/toolbarFixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ type LengthUnitLabel = (typeof baseUnitLabels)[keyof typeof baseUnitLabels]
export class ToolbarFixture {
public page: Page

projectName!: Locator
fileName!: Locator
extrudeButton!: Locator
loftButton!: Locator
sweepButton!: Locator
Expand Down Expand Up @@ -55,8 +53,6 @@ export class ToolbarFixture {
constructor(page: Page) {
this.page = page

this.projectName = page.getByTestId('app-header-project-name')
this.fileName = page.getByTestId('app-header-file-name')
this.extrudeButton = page.getByTestId('extrude')
this.loftButton = page.getByTestId('loft')
this.sweepButton = page.getByTestId('sweep')
Expand Down
8 changes: 4 additions & 4 deletions e2e/playwright/native-file-menu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ test.describe(
)
await expect(actual).toBeVisible()
})
test('Home.Help.Replay onboarding tutorial', async ({
test('Home.Help.Reset onboarding', async ({
tronApp,
cmdBar,
page,
Expand All @@ -464,7 +464,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) return false
const menu = app.applicationMenu.getMenuItemById(
'Help.Replay onboarding tutorial'
'Help.Reset onboarding'
)
if (!menu) {
return false
Expand Down Expand Up @@ -2339,7 +2339,7 @@ test.describe(
await scene.connectionEstablished()
await expect(toolbar.startSketchBtn).toBeVisible()
})
test('Modeling.Help.Replay onboarding tutorial', async ({
test('Modeling.Help.Reset onboarding', async ({
tronApp,
cmdBar,
page,
Expand All @@ -2358,7 +2358,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) fail()
const menu = app.applicationMenu.getMenuItemById(
'Help.Replay onboarding tutorial'
'Help.Reset onboarding'
)
if (!menu) fail()
menu.click()
Expand Down
Loading
Loading