Assemblies: Load outside files into project via point-and-click by pierremtb · Pull Request #6217 · KittyCAD/modeling-app

pierremtb · 2025-04-08T17:03:41Z

Includes:

Moving the Insert button from the sidebar to the modeling toolbar, creating a new 'modules' group with Insert and Transform, the latter is disabled for now until Set translate and rotate via point-and-click on imports #6020. Transform doesn't only apply to inserted models of course, but it seems fitting to have it there at least for the time being. Happy to take in feedback, see updated snapshots!
Extending the Open sample command into a new Load external model command that can use the regular kcl-samples source or a Local Disk source, allowing people to load downloaded files into their project. And this could potentially extended to other sources later of course. Supports both KCL and non-KCL files.
A new sidebar button for Load external model that takes the place of Insert button
Tests for all the above

Doesn't include: probably a lot of gotchas! Follow-up PRs to come, we're definitely not closing the meta-issue for assemblies just yet. This is still behind a DEV || IS NIGHTLY flag.

Demo:

Screen.Recording.2025-04-14.at.10.12.17.AM.mov

Will eventually fix #6120 Right now the whole loop is there but the codemod doesn't work yet

…rt-for-geometry

Fixes #6152

Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>

…rt-for-geometry

…etry' into pierremtb/issue6152-UX-improvements-around-foreign-file-imports

Fixes #6152

@Irev-Dev

Thanks @Irev-Dev for the suggestion

…-to-copy-files-from-outside-the-project-into-the-project

franknoirot

Just a couple suggestions, I could debate them or be convinced that they can be follow-ups though. Very fun user flows.

e2e/playwright/testing-samples-loading.spec.ts

franknoirot · 2025-04-14T15:09:17Z

e2e/playwright/testing-samples-loading.spec.ts

+
+        await test.step('Load the external model from local drive', async () => {
+          await loadExternalFileThroughCommandBar(tronApp)
+          // TODO: I think the files pane should auto open?


This is interesting. Once I get just a bit of bandwidth I think we should talk about a future UI where file management, feature tree, and code pane aren't so disparate. Then we won't need to manage the state of the panes so much to make the UX smooth.

src/components/CommandBar/CommandBarArgument.tsx

src/components/CommandBar/CommandBarPathDialogInput.tsx

franknoirot · 2025-04-14T15:16:54Z

src/lib/kclCommands.ts

 interface OnSubmitProps {
-  sampleName: string
-  code: string
-  sampleUnits?: UnitLength_type


Thank you for finally ridding us of this

src/lib/kclCommands.ts

@franknoirot

Thanks @franknoirot! Co-authored-by: Frank Noirot <frank@zoo.dev>

…-to-copy-files-from-outside-the-project-into-the-project

franknoirot

Thanks for the changes! Tested locally and things are looking good.

@Irev-Dev

…lick (#6217) * WIP: Add point-and-click Import for geometry Will eventually fix #6120 Right now the whole loop is there but the codemod doesn't work yet * Better pathToNOde, log on non-working cm dispatch call * Add workaround to updateModelingState not working * Back to updateModelingState with a skip flag * Better todo * Change working from Import to Insert, cleanups * Sister command in kclCommands to populate file options * Improve path selector * Unsure: move importAstMod to kclCommands onSubmit 😶 * Add e2e test * Clean up for review * Add native file menu entry and test * No await yo lint said so * WIP: UX improvements around foreign file imports Fixes #6152 * @lrev-Dev's suggestion to remove a comment Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> * Update to scene.settled(cmdBar) * Add partNNN default name for alias * Lint * Lint * Fix unit tests * Add sad path insert test Thanks @Irev-Dev for the suggestion * Add step insert test * Lint * Add test for second foreign import thru file tree click * WIP: Add point-and-click Load to copy files from outside the project into the project Towards #6210 * Move Insert button to modeling toolbar, update menus and toolbars * Add default value for local name alias * Aligning tests * Fix tests * Add padding for filenames starting with a digit * Lint * Lint * Update snapshots * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Add disabled transform subbutton * Merge kcl-samples and local disk load into one 'Load external model' command * Fix em tests * Fix test * Add test for file pick import, better input * Fix non .kcl loading * Lint * Update snapshots * Fix issue leading to test failure * Fix clone test * Add note * Fix nested clone issue * Clean up for review * Add valueSummary for path * Fix test after path change * Clean up for review * Update src/lib/kclCommands.ts Thanks @franknoirot! Co-authored-by: Frank Noirot <frank@zoo.dev> * Improve path input arg * Fix tests * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Fix path header not showing and improve tests * Clean up --------- Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> Co-authored-by: Frank Noirot <frank@zoo.dev>

@Irev-Dev

…lick (#6217) * WIP: Add point-and-click Import for geometry Will eventually fix #6120 Right now the whole loop is there but the codemod doesn't work yet * Better pathToNOde, log on non-working cm dispatch call * Add workaround to updateModelingState not working * Back to updateModelingState with a skip flag * Better todo * Change working from Import to Insert, cleanups * Sister command in kclCommands to populate file options * Improve path selector * Unsure: move importAstMod to kclCommands onSubmit 😶 * Add e2e test * Clean up for review * Add native file menu entry and test * No await yo lint said so * WIP: UX improvements around foreign file imports Fixes #6152 * @lrev-Dev's suggestion to remove a comment Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> * Update to scene.settled(cmdBar) * Add partNNN default name for alias * Lint * Lint * Fix unit tests * Add sad path insert test Thanks @Irev-Dev for the suggestion * Add step insert test * Lint * Add test for second foreign import thru file tree click * WIP: Add point-and-click Load to copy files from outside the project into the project Towards #6210 * Move Insert button to modeling toolbar, update menus and toolbars * Add default value for local name alias * Aligning tests * Fix tests * Add padding for filenames starting with a digit * Lint * Lint * Update snapshots * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Add disabled transform subbutton * Merge kcl-samples and local disk load into one 'Load external model' command * Fix em tests * Fix test * Add test for file pick import, better input * Fix non .kcl loading * Lint * Update snapshots * Fix issue leading to test failure * Fix clone test * Add note * Fix nested clone issue * Clean up for review * Add valueSummary for path * Fix test after path change * Clean up for review * Update src/lib/kclCommands.ts Thanks @franknoirot! Co-authored-by: Frank Noirot <frank@zoo.dev> * Improve path input arg * Fix tests * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Fix path header not showing and improve tests * Clean up --------- Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> Co-authored-by: Frank Noirot <frank@zoo.dev>

@Irev-Dev

…lick (#6217) * WIP: Add point-and-click Import for geometry Will eventually fix #6120 Right now the whole loop is there but the codemod doesn't work yet * Better pathToNOde, log on non-working cm dispatch call * Add workaround to updateModelingState not working * Back to updateModelingState with a skip flag * Better todo * Change working from Import to Insert, cleanups * Sister command in kclCommands to populate file options * Improve path selector * Unsure: move importAstMod to kclCommands onSubmit 😶 * Add e2e test * Clean up for review * Add native file menu entry and test * No await yo lint said so * WIP: UX improvements around foreign file imports Fixes #6152 * @lrev-Dev's suggestion to remove a comment Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> * Update to scene.settled(cmdBar) * Add partNNN default name for alias * Lint * Lint * Fix unit tests * Add sad path insert test Thanks @Irev-Dev for the suggestion * Add step insert test * Lint * Add test for second foreign import thru file tree click * WIP: Add point-and-click Load to copy files from outside the project into the project Towards #6210 * Move Insert button to modeling toolbar, update menus and toolbars * Add default value for local name alias * Aligning tests * Fix tests * Add padding for filenames starting with a digit * Lint * Lint * Update snapshots * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Add disabled transform subbutton * Merge kcl-samples and local disk load into one 'Load external model' command * Fix em tests * Fix test * Add test for file pick import, better input * Fix non .kcl loading * Lint * Update snapshots * Fix issue leading to test failure * Fix clone test * Add note * Fix nested clone issue * Clean up for review * Add valueSummary for path * Fix test after path change * Clean up for review * Update src/lib/kclCommands.ts Thanks @franknoirot! Co-authored-by: Frank Noirot <frank@zoo.dev> * Improve path input arg * Fix tests * Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project * Fix path header not showing and improve tests * Clean up --------- Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> Co-authored-by: Frank Noirot <frank@zoo.dev>

pierremtb and others added 30 commits April 2, 2025 17:04

WIP: Add point-and-click Import for geometry

9001006

Will eventually fix #6120 Right now the whole loop is there but the codemod doesn't work yet

Better pathToNOde, log on non-working cm dispatch call

3afcb33

Add workaround to updateModelingState not working

e00f6c2

Back to updateModelingState with a skip flag

2bae5ff

Better todo

79fd435

Update from main

2d08d47

Change working from Import to Insert, cleanups

1bb37fc

Sister command in kclCommands to populate file options

9371860

Merge branch 'main' into pierremtb/issue6120-Add-point-and-click-Impo…

69a0198

…rt-for-geometry

Merge branch 'main' into pierremtb/issue6120-Add-point-and-click-Impo…

58c87ac

…rt-for-geometry

Improve path selector

9e32ce3

Merge branch 'main' into pierremtb/issue6120-Add-point-and-click-Impo…

5d8f7a5

…rt-for-geometry

Unsure: move importAstMod to kclCommands onSubmit 😶

7b7d8b4

Add e2e test

eaf1f09

Clean up for review

8052af8

Merge branch 'main' into pierremtb/issue6120-Add-point-and-click-Impo…

efcf164

…rt-for-geometry

Add native file menu entry and test

8fa8b16

No await yo lint said so

5f11d61

WIP: UX improvements around foreign file imports

f36905b

Fixes #6152

@lrev-Dev's suggestion to remove a comment

4698339

Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>

Merge branch 'main' into pierremtb/issue6120-Add-point-and-click-Impo…

a932339

…rt-for-geometry

Update to scene.settled(cmdBar)

c5e18ba

Merge branch 'pierremtb/issue6120-Add-point-and-click-Import-for-geom…

ea6eaf5

…etry' into pierremtb/issue6152-UX-improvements-around-foreign-file-imports

Add partNNN default name for alias

7689afb

UX improvements around foreign file imports

36c17fd

Fixes #6152

Lint

cbaf345

Lint

b098d8c

Fix unit tests

60c3580

Add sad path insert test

3c38880

Thanks @Irev-Dev for the suggestion

Add step insert test

7574663

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

80ee0b8

…-to-copy-files-from-outside-the-project-into-the-project

vercel bot deployed to Preview April 12, 2025 03:15 View deployment

Fix test after path change

ecf9ab4

vercel bot deployed to Preview April 12, 2025 10:38 View deployment

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

ef333b5

…-to-copy-files-from-outside-the-project-into-the-project

vercel bot deployed to Preview April 14, 2025 08:55 View deployment

pierremtb added 2 commits April 14, 2025 09:34

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

df0487e

…-to-copy-files-from-outside-the-project-into-the-project

Clean up for review

d09162e

vercel bot deployed to Preview April 14, 2025 14:14 View deployment

pierremtb requested a review from franknoirot April 14, 2025 14:15

franknoirot reviewed Apr 14, 2025

View reviewed changes

Update src/lib/kclCommands.ts

9a03b4e

Thanks @franknoirot! Co-authored-by: Frank Noirot <frank@zoo.dev>

vercel bot deployed to Preview April 14, 2025 15:39 View deployment

Improve path input arg

a709e89

vercel bot deployed to Preview April 14, 2025 16:59 View deployment

pierremtb added 4 commits April 14, 2025 13:22

Fix tests

941e72c

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

c16c829

…-to-copy-files-from-outside-the-project-into-the-project

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

6540d98

…-to-copy-files-from-outside-the-project-into-the-project

Fix path header not showing and improve tests

4a68aae

vercel bot deployed to Preview April 14, 2025 17:59 View deployment

pierremtb and others added 2 commits April 14, 2025 14:14

Clean up

667aaa6

Merge branch 'main' into pierremtb/issue6210-Add-point-and-click-Load…

2ab276b

…-to-copy-files-from-outside-the-project-into-the-project

franknoirot approved these changes Apr 14, 2025

View reviewed changes

vercel bot deployed to Preview April 14, 2025 18:38 View deployment

pierremtb enabled auto-merge (squash) April 14, 2025 18:45

pierremtb merged commit add1b21 into main Apr 14, 2025
40 checks passed

pierremtb deleted the pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project branch April 14, 2025 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assemblies: Load outside files into project via point-and-click#6217

Assemblies: Load outside files into project via point-and-click#6217
pierremtb merged 84 commits intomainfrom
pierremtb/issue6210-Add-point-and-click-Load-to-copy-files-from-outside-the-project-into-the-project

pierremtb commented Apr 8, 2025 •

edited

Loading

Uh oh!

franknoirot left a comment

Uh oh!

Uh oh!

Uh oh!

franknoirot Apr 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franknoirot Apr 14, 2025

Uh oh!

Uh oh!

franknoirot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pierremtb commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

franknoirot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

franknoirot Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franknoirot Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

franknoirot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pierremtb commented Apr 8, 2025 •

edited

Loading