Skip to content

Remove Text-to-CAD snapshot test#6216

Closed
jacebrowning wants to merge 2 commits intomainfrom
remove-ai-snapshots
Closed

Remove Text-to-CAD snapshot test#6216
jacebrowning wants to merge 2 commits intomainfrom
remove-ai-snapshots

Conversation

@jacebrowning
Copy link
Contributor

@jacebrowning jacebrowning commented Apr 8, 2025

I don't think this should be in the modeling app. A snapshot test that depends on AI will be inherently unreliable. I would expect Text-to-CAD to have their own way of capturing real-world API requests for regression testing.

@jacebrowning jacebrowning self-assigned this Apr 8, 2025
@qa-wolf
Copy link

qa-wolf bot commented Apr 8, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 8, 2025 5:32pm

@jacebrowning jacebrowning force-pushed the remove-ai-snapshots branch from b038241 to c5fa830 Compare April 8, 2025 16:09
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (c3097aa) to head (76f920c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6216   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files         109      109           
  Lines       44651    44651           
=======================================
  Hits        37991    37991           
  Misses       6660     6660           
Flag Coverage Δ
rust 85.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacebrowning
Copy link
Contributor Author

It sounds like we still need this snapshots for AI testing (thread) so we'll try to make these tests more reliable instead: #6225

@jacebrowning jacebrowning deleted the remove-ai-snapshots branch April 8, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants