Skip to content

Remove unnecessary timeouts waiting for command bar #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierremtb merged 1 commit into from
Apr 7, 2025
Merged

Remove unnecessary timeouts waiting for command bar #6199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions e2e/playwright/desktop-export.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,28 +38,24 @@ test(
await expect(projectName).toBeVisible()
await projectName.click()
await scene.settled(cmdBar)
await page.waitForTimeout(1_000) // wait for panel buttons to be available

// Expect zero errors in gutter
await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()

// Click the export button
const exportButton = page.getByTestId('export-pane-button')
await expect(exportButton).toBeVisible()

await exportButton.click()
await page.waitForTimeout(1_000) // wait for export options to be available

// Select the first format option
const gltfOption = page.getByText('glTF')
const gltfOption = cmdBar.selectOption({ name: 'glTF' })
const exportFileName = `main.gltf` // source file is named `main.kcl`
await expect(gltfOption).toBeVisible()
await page.keyboard.press('Enter')

// Click the checkbox
const submitButton = page.getByText('Confirm Export')
await expect(submitButton).toBeVisible()
await page.waitForTimeout(500)
await page.keyboard.press('Enter')

// Look out for the toast message
Expand Down Expand Up @@ -113,25 +109,23 @@ test(
await u.closeFilePanel()
await scene.settled(cmdBar)

// expect zero errors in guter
// Expect zero errors in gutter
await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()

// Click the export button
const exportButton = page.getByTestId('export-pane-button')
await expect(exportButton).toBeVisible()
await exportButton.click()
await page.waitForTimeout(1_000) // wait for export options to be available

// Select the first format option
const gltfOption = page.getByText('glTF')
const gltfOption = cmdBar.selectOption({ name: 'glTF' })
const exportFileName = `other.gltf` // source file is named `other.kcl`
await expect(gltfOption).toBeVisible()
await page.keyboard.press('Enter')

// Click the checkbox
const submitButton = page.getByText('Confirm Export')
await expect(submitButton).toBeVisible()
await page.waitForTimeout(500)
await page.keyboard.press('Enter')

// Look out for the toast message
Expand Down
Loading