Skip to content

Follow-up fixes after bearing sample rename #6164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierremtb merged 1 commit into from
Apr 5, 2025
Merged

Follow-up fixes after bearing sample rename #6164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions e2e/playwright/testing-samples-loading.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import { expect, test } from '@e2e/playwright/zoo-test'

test.describe('Testing in-app sample loading', () => {
/**
* Note this test implicitly depends on the KCL sample "a-parametric-bearing-pillow-block",
* its title, and its units settings. https://github.com/KittyCAD/kcl-samples/blob/main/a-parametric-bearing-pillow-block/main.kcl
* Note this test implicitly depends on the KCL sample "parametric-bearing-pillow-block",
* its title, and its units settings. https://github.com/KittyCAD/kcl-samples/blob/main/parametric-bearing-pillow-block/main.kcl
*/
test('Web: should overwrite current code, cannot create new file', async ({
editor,
Expand All @@ -29,8 +29,8 @@ test.describe('Testing in-app sample loading', () => {

// Locators and constants
const newSample = {
file: 'a-parametric-bearing-pillow-block' + FILE_EXT,
title: 'A Parametric Bearing Pillow Block',
file: 'parametric-bearing-pillow-block' + FILE_EXT,
title: 'Parametric Bearing Pillow Block',
}
const commandBarButton = page.getByRole('button', { name: 'Commands' })
const samplesCommandOption = page.getByRole('option', {
Expand Down Expand Up @@ -72,7 +72,7 @@ test.describe('Testing in-app sample loading', () => {

/**
* Note this test implicitly depends on the KCL samples:
* "a-parametric-bearing-pillow-block": https://github.com/KittyCAD/kcl-samples/blob/main/a-parametric-bearing-pillow-block/main.kcl
* "parametric-bearing-pillow-block": https://github.com/KittyCAD/kcl-samples/blob/main/parametric-bearing-pillow-block/main.kcl
* "gear-rack": https://github.com/KittyCAD/kcl-samples/blob/main/gear-rack/main.kcl
*/
test(
Expand All @@ -90,8 +90,8 @@ test.describe('Testing in-app sample loading', () => {

// Locators and constants
const sampleOne = {
file: 'a-parametric-bearing-pillow-block' + FILE_EXT,
title: 'A Parametric Bearing Pillow Block',
file: 'parametric-bearing-pillow-block' + FILE_EXT,
title: 'Parametric Bearing Pillow Block',
}
const sampleTwo = {
file: 'gear-rack' + FILE_EXT,
Expand Down
Binary file removed public/kcl-samples/screenshots/a-parametric-bearing-pillow-block.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/lib/kclSamplesArray.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
"80-20-rail",
"a-parametric-bearing-pillow-block",
"parametric-bearing-pillow-block",
Copy link
Contributor Author

@pierremtb pierremtb Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up during global search, not sure where it's used

"ball-bearing",
"bracket",
"brake-caliper",
Expand Down
2 changes: 1 addition & 1 deletion src/routes/SignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ const SignIn = () => {
<div className="flex gap-4 flex-wrap items-center">
<ActionButton
Element="externalLink"
to="https://zoo.dev/docs/kcl-samples/a-parametric-bearing-pillow-block"
to="https://zoo.dev/docs/kcl-samples/parametric-bearing-pillow-block"
Copy link
Contributor Author

@pierremtb pierremtb Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what broke a home page link on the released app

iconStart={{
icon: 'settings',
bgClassName: '!bg-transparent',
Expand Down
Loading