Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sync Past Orders when HPOS Disabled #201

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Nov 15, 2024

Summary

Fixes this reported issue, due to this change, meaning that the Sync Past Orders functionality could determine which Orders need to be sent to Kit's purchase data API endpoint when WooCommerce's HPOS is not enabled (as was the case with this creator's site), resulting in it attempting to send all Orders.

Testing

  • SyncPastOrdersHPOSCest: Renamed from SyncPastOrdersCest. Runs tests with HPOS enabled.
  • SyncPastOrdersHPOSCLICest: Renamed from SyncPastOrdersCLICest. Run tests in CLI with HPOS enabled.
  • SyncPastOrdersCest: Run tests with HPOS disabled.
  • SyncPastOrdersCLICest: Run CLI tests with HPOS disabled.

Checklist

@n7studios n7studios added the bug label Nov 15, 2024
@n7studios n7studios self-assigned this Nov 15, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team November 15, 2024 10:01
@n7studios n7studios marked this pull request as ready for review November 15, 2024 10:03
@n7studios n7studios merged commit 5df8c6e into main Nov 16, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants