Skip to content

Don't force lazy message formatting for every message record #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KirillOsenkov merged 1 commit into from
Aug 19, 2026
+12 −1
Merged

Don't force lazy message formatting for every message record #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/StructuredLogger/BinaryLogger/BuildEventArgsReader.Viewer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,18 @@ private BuildEventArgs SynthesizePropertyReassignment(BuildEventArgsFields field
private bool sawCulture;

private void OnMessageRead(BuildMessageEventArgs args)
=> ProcessCultureMessage(args.SenderName, args.Message);
{
// Check sawCulture before reading args.Message. BuildMessageEventArgs.Message is
// lazily formatted, so touching it runs string.Format over the event's arguments and
// allocates a string. The culture marker is emitted at the very start of the log, so
// for virtually every message record that work is immediately thrown away.
if (sawCulture)
{
return;
}

ProcessCultureMessage(args.SenderName, args.Message);
}

private bool ProcessCultureMessage(string senderName, string message)
{
Expand Down