Skip to content

Fix binlog argument passing for output file #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix binlog argument passing for output file #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/BinlogTool/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,11 @@ binlogtool search *.binlog search string
return 0;
}

if (string.Equals(firstArg, "compilerinvocations", StringComparison.OrdinalIgnoreCase))
if (args.Length >= 2 && string.Equals(firstArg, "compilerinvocations", StringComparison.OrdinalIgnoreCase))
{
string binlog = null;
string binlog = binlog = args[1];
Copy link
Owner

@KirillOsenkov KirillOsenkov Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= binlog = binlog is duplicated

Copy link
Owner

@KirillOsenkov KirillOsenkov Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it myself

string outputFile = null;
if (args.Length >= 2)
{
binlog = args[1];
}
else if (args.Length == 3)
if (args.Length == 3)
{
outputFile = args[2];
}
Expand All @@ -104,15 +100,11 @@ binlogtool search *.binlog search string
return 0;
}

if (string.Equals(firstArg, "doublewrites", StringComparison.OrdinalIgnoreCase))
if (args.Length >= 2 && string.Equals(firstArg, "doublewrites", StringComparison.OrdinalIgnoreCase))
{
string binlog = null;
string binlog = binlog = args[1];
Copy link
Owner

@KirillOsenkov KirillOsenkov Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

string outputFile = null;
if (args.Length >= 2)
{
binlog = args[1];
}
else if (args.Length == 3)
if (args.Length == 3)
{
outputFile = args[2];
}
Expand Down