Skip to content

Speed up double writes analyzer #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KirillOsenkov merged 1 commit into from
Feb 24, 2025
+4 −20
Merged

Speed up double writes analyzer #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions src/StructuredLogger/Analyzers/DoubleWritesAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
Expand All @@ -12,7 +12,7 @@ public class DoubleWritesAnalyzer
public static IEnumerable<KeyValuePair<string, HashSet<string>>> GetDoubleWrites(Build build)
{
var analyzer = new DoubleWritesAnalyzer();
build.VisitAllChildren<Task>(task => analyzer.AnalyzeTask(task));
build.VisitAllChildren<Task>(analyzer.AnalyzeTask);
return analyzer.GetDoubleWrites();
}

Expand Down Expand Up @@ -93,26 +93,10 @@ private void ProcessCopy(string source, string destination)
fileCopySourcesForDestination.Add(destination, bucket);
}

bucket.Add(source);
bucket.Add(GetFullPath(source));
}

private static bool IsDoubleWrite(KeyValuePair<string, HashSet<string>> bucket)
{
if (bucket.Value.Count < 2)
{
return false;
}

if (bucket.Value
.Select(f => GetFullPath(f))
.Distinct()
.Count() == 1)
{
return false;
}

return true;
}
private static bool IsDoubleWrite(KeyValuePair<string, HashSet<string>> bucket) => bucket.Value.Count > 1;

private static string GetFullPath(string filePath)
{
Expand Down