Fix use of server GC for .NET 8 build#819
Merged
KirillOsenkov merged 1 commit intoKirillOsenkov:mainfrom Sep 17, 2024
Merged
Conversation
KirillOsenkov
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's what top-level CPU consumption looks like in a run with the netfx build up until it's done reading the input:
It's using server GC, thanks to:
MSBuildStructuredLog/src/StructuredLogViewer/App.config
Line 15 in 2744686
Here's what it looks like on core before this change:
It doesn't respect that app.config, hence using workstation GC. Note it's flat, pegging only a single core, rather than utilizing more, due to being bottlenecked on GC.
Now with the one-line fix:
