Skip to content

Improve searching for Messages with a timespan. #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KirillOsenkov merged 1 commit into from
Jun 14, 2024
+13 −1
Merged

Improve searching for Messages with a timespan. #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/StructuredLogger/Search/NodeQueryMatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,11 +796,23 @@ public SearchResult IsMatch(params string[] fields)

public bool IsTimeIntervalMatch(BaseNode node)
{
if (!HasTimeIntervalConstraints || node is not TimedNode timedNode)
if (!HasTimeIntervalConstraints)
{
return true;
}

// Messages and Folders are not timed nodes, using the parent instead.
if (node is not TimedNode timedNode)
{
var parentNode = node.GetNearestParent<TimedNode>();
if (parentNode is null)
{
return true;
}

timedNode = parentNode;
}

if (StartBefore != default && timedNode.StartTime > StartBefore)
{
return false;
Expand Down