Skip to content

Commit

Permalink
Ensure that the help viewer keeps running as long as its main frame i…
Browse files Browse the repository at this point in the history
…s opened.

Do prevent the app from exiting when the help frame is shown in the special
case of the help viewer application where the default behaviour of exiting the
application when only the help window remains open is inappropriate and
results in unexpected program exit if we open and then close any dialog, e.g.
from the help frame toolbar.

Even though the previous commit actually already fixed the problem in the
current code, still apply this fix as well, just in case we can (or could, in
the future) should any dialogs with NULL parent in this program.

Closes wxWidgets#15880.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75634 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
  • Loading branch information
vadz committed Jan 16, 2014
1 parent 5575917 commit 9084dd3
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions utils/helpview/src/helpview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ bool hvApp::OnInit()

m_helpController = new wxHtmlHelpController( istyle );

// By default, the application doesn't continue running if only the help
// frame remains. This makes sense for the programs doing something else
// and also showing help, but as this one only shows help, we should keep
// it running as long as this frame is opened.
m_helpController->SetShouldPreventAppExit(true);

if ( !hasWindowName )
{
titleFormat = wxT("Help: %s") ;
Expand Down

0 comments on commit 9084dd3

Please sign in to comment.