Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI python versions #31

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Update CI python versions #31

merged 9 commits into from
Nov 8, 2024

Conversation

Kilo59
Copy link
Owner

@Kilo59 Kilo59 commented Nov 8, 2024

Summary by Sourcery

CI:

  • Update the CI configuration to test against Python versions 3.9, 3.10, 3.11, 3.12, and 3.13, removing support for versions 3.7 and 3.8.

Copy link
Contributor

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR updates the CI workflow configuration to test against newer Python versions. The change removes testing for older Python versions (3.7 and 3.8) and adds support for newer versions (3.11, 3.12, and 3.13), while maintaining testing for Python 3.9 and 3.10.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Python version matrix in CI workflow
  • Removed Python 3.7 and 3.8 from test matrix
  • Added Python 3.11, 3.12, and 3.13 to test matrix
  • Maintained testing for Python 3.9 and 3.10
.github/workflows/ci.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kilo59 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing Python 3.13 from the test matrix since it's not yet released. This can be added back once Python 3.13 is officially available.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 8, 2024

@Kilo59
Copy link
Owner Author

Kilo59 commented Nov 8, 2024

@sourcery-ai review

@Kilo59 Kilo59 merged commit 9cbfd8e into main Nov 8, 2024
15 checks passed
@Kilo59 Kilo59 deleted the b/fix-ci branch November 8, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant