You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Access to the Skill tool was revoked from many agents, such as Plan, Ask, and Explore. This is undesirable. This change restores access to the Skill tool to all non-system agents as allow-by-default, so that the agent can load skills.
This makes sense. skill is permission-gated, and these agents use * = deny allowlists. Code mode still inherited * = allow, but Ask/Plan/Explore/Orchestrator never explicitly allowed skill, so once skills were filtered through agent permissions they disappeared for those modes instead of failing loudly.
The regression started with upstream 0f6bc8ae71 / OpenCode #17053, which moved skill discovery into the system prompt and skips it when Permission.disabled(["skill"], agent.permission) says the tool is disabled. That made missing skill: "allow" visible for allowlisted agents. Later upstream 17bd16667c / OpenCode #21795 moved the skill tool description into the registry and used the same skill.available(agent) permission filtering there too, so the tool description path had the same issue.
This PR adds skill: "allow" to the non-system allowlisted agents and keeps system agents denied, which matches the intended split. The regression test is the important part here so we don’t lose this again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Access to the Skill tool was revoked from many agents, such as Plan, Ask, and Explore. This is undesirable. This change restores access to the Skill tool to all non-system agents as allow-by-default, so that the agent can load skills.
Screenshots
Get in Touch
ExpedientFalcon on Discord