Skip to content

fix(core): restore Skill tool as allow by default#9924

Merged
marius-kilocode merged 1 commit into
Kilo-Org:mainfrom
shssoichiro:restore-skill-tool
May 5, 2026
Merged

fix(core): restore Skill tool as allow by default#9924
marius-kilocode merged 1 commit into
Kilo-Org:mainfrom
shssoichiro:restore-skill-tool

Conversation

@shssoichiro
Copy link
Copy Markdown
Contributor

@shssoichiro shssoichiro commented May 5, 2026

Context

Access to the Skill tool was revoked from many agents, such as Plan, Ask, and Explore. This is undesirable. This change restores access to the Skill tool to all non-system agents as allow-by-default, so that the agent can load skills.

Screenshots

image

Get in Touch

ExpedientFalcon on Discord

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 5, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/skill-tool-default-agents.md
  • packages/opencode/src/kilocode/agent/index.ts
  • packages/opencode/test/kilocode/agent-skill-permissions.test.ts

Reviewed by gpt-5.5-2026-04-23 · 179,307 tokens

@marius-kilocode marius-kilocode self-requested a review May 5, 2026 16:08
@marius-kilocode
Copy link
Copy Markdown
Collaborator

This makes sense. skill is permission-gated, and these agents use * = deny allowlists. Code mode still inherited * = allow, but Ask/Plan/Explore/Orchestrator never explicitly allowed skill, so once skills were filtered through agent permissions they disappeared for those modes instead of failing loudly.

The regression started with upstream 0f6bc8ae71 / OpenCode #17053, which moved skill discovery into the system prompt and skips it when Permission.disabled(["skill"], agent.permission) says the tool is disabled. That made missing skill: "allow" visible for allowlisted agents. Later upstream 17bd16667c / OpenCode #21795 moved the skill tool description into the registry and used the same skill.available(agent) permission filtering there too, so the tool description path had the same issue.

This PR adds skill: "allow" to the non-system allowlisted agents and keeps system agents denied, which matches the intended split. The regression test is the important part here so we don’t lose this again.

@marius-kilocode
Copy link
Copy Markdown
Collaborator

#9556 looks like the root cause

@marius-kilocode marius-kilocode merged commit 914bbdf into Kilo-Org:main May 5, 2026
20 checks passed
@marius-kilocode
Copy link
Copy Markdown
Collaborator

Thanks @shssoichiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants