refactor(cli): flatten Encoding/EncodedIO namespaces to module exports#9918
Merged
Conversation
Replace `export namespace Encoding`/`EncodedIO` wrappers with top-level exports and switch consumers to `import * as Encoding`/`EncodedIO`. The module itself acts as the namespace, avoiding the TS-namespace wrapper that tree-shakers and some module resolvers handle awkwardly.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by gpt-5.5-20260423 · 198,330 tokens |
marius-kilocode
approved these changes
May 5, 2026
…orts # Conflicts: # packages/opencode/src/kilocode/encoding.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export namespace Encoding/export namespace EncodedIOwrappers with top-level module exports.import * as Encoding/import * as EncodedIO, letting the module itself act as the namespace.Why
Per review feedback, the namespace-as-wrapper pattern is unusual and can be fragile under tree-shaking / differing module resolution strategies. Using the module-as-namespace via
import * asis more idiomatic and behaves consistently across tooling.