Skip to content

refactor(cli): inline question-tool client gating #9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markijbema wants to merge 2 commits into from
Closed

refactor(cli): inline question-tool client gating #9811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6598e4a
refactor(cli): inline question-tool client gating
kilo-code-bot[bot] Apr 30, 2026
a715467
chore(cli): use block kilocode_change markers
kilo-code-bot[bot] Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/opencode/src/kilocode/tool/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ export namespace KiloToolRegistry {

function semanticTool(deps: Deps) {
return Effect.gen(function* () {
const ready = yield* Effect.tryPromise(() => import("@/kilocode/indexing").then((mod) => mod.KiloIndexing.ready())).pipe(
const ready = yield* Effect.tryPromise(() =>
import("@/kilocode/indexing").then((mod) => mod.KiloIndexing.ready()),
).pipe(
Effect.catch((err) =>
Effect.sync(() => {
log.warn("semantic search unavailable", { err })
Expand Down Expand Up @@ -66,11 +68,6 @@ export namespace KiloToolRegistry {
})
}

/** Override question-tool client gating (adds "vscode" to allowed clients) */
export function question(): boolean {
return ["app", "cli", "desktop", "vscode"].includes(Flag.KILO_CLIENT) || Flag.KILO_ENABLE_QUESTION_TOOL
}

/** Plan tool is always registered in Kilo (gated by agent permission instead) */
export function plan(): boolean {
return true
Expand Down
5 changes: 4 additions & 1 deletion packages/opencode/src/tool/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ export const layer: Layer.Layer<
}

const cfg = yield* config.get()
const questionEnabled = KiloToolRegistry.question() // kilocode_change
// kilocode_change start: add "vscode" to allowed clients
const questionEnabled =
["app", "cli", "desktop", "vscode"].includes(Flag.KILO_CLIENT) || Flag.KILO_ENABLE_QUESTION_TOOL
// kilocode_change end

// kilocode_change start
const tool = yield* Effect.all({
Expand Down
Loading