fix(cli): fix slow CLI startup - #9455
Merged
Merged
Conversation
Drop a debug short-circuit shipped upstream in #23037 that flipped `sync.ready` before sync actually finished, producing a 1-2s delay before home content (agents, news, tips) appeared in the TUI. Bisected from origin/main.
alex-alecu
changed the title
return true in sync.ready
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 90,624 tokens |
imanolmzd-svg
approved these changes
Apr 24, 2026
imanolmzd-svg
self-requested a review
April 24, 2026 06:57
imanolmzd-svg
suggested changes
Apr 24, 2026
imanolmzd-svg
approved these changes
Apr 24, 2026
alex-alecu
enabled auto-merge
April 24, 2026 07:21
marius-kilocode
approved these changes
Apr 24, 2026
jliounis
pushed a commit
to jliounis/kilocode
that referenced
this pull request
May 18, 2026
…ug-leftover fix(cli): fix slow CLI startup
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…ug-leftover fix(cli): fix slow CLI startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.readyalways true, leaving the rest of the getter unreachable.readywas flipping before sync actually finished and downstream consumers were racing it.Bisected from
origin/main(a915fe74be2good →dd7b3c894fdbad) to65b2a10e97d("fade in prompt metadata transitions"). This PR undoes only the sync.tsx portion of that commit; the fade-in animation added in the same upstream commit is a separate issue tracked on the Kilo fork.Testing
Compare
bun devonmainvsfix/cli-sync-ready-debug-leftover.Screen.Recording.2026-04-24.at.09.46.01.mov