-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: implement native OS notifications and sound alerts #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
IamCoder18
wants to merge
22
commits into
Kilo-Org:main
from
IamCoder18:feat/issue-7048-system-notifications
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3cbfbb6
feat(vscode): implement native OS notifications
IamCoder18 db6d1ee
feat(vscode): add sound playback to OS notifications
IamCoder18 3a0dd07
fix(vscode): resolve sound file paths and add all sound options to UI
IamCoder18 e2b161c
fix(vscode): add audio/ to .vscodeignore and remove test command
IamCoder18 2f1c196
fix(vscode): guard onDidChangeWindowState for test compatibility
IamCoder18 33fccbe
fix: resolve windows notification encoding and path validation
IamCoder18 e7b577e
fix(vscode): resolve notification escaping and sound path validation
IamCoder18 be14b55
fix(vscode): harden notification escaping, sound path injection, and …
IamCoder18 83433ff
fix(vscode): allow apostrophes and Unicode in sound file paths
IamCoder18 10ba427
fix(vscode): expand sound path whitelist to allow common path characters
IamCoder18 74837a9
fix(vscode): replace path whitelist with control-char blocklist
IamCoder18 d1e6920
fix(vscode): add logging to notification and sound catch blocks
IamCoder18 c2a3649
feat(vscode): use terminal-notifier for macOS notifications with osas…
IamCoder18 4e4f910
fix(vscode): deduplicate OS notifications across multiple webview panels
IamCoder18 30b5ab6
fix(vscode): pass raw text to terminal-notifier instead of AppleScrip…
IamCoder18 244f901
fix(vscode): include requestID in notification dedup key to prevent s…
IamCoder18 f605e44
feat(vscode): add system sound option for notifications
IamCoder18 e3884bc
fix(vscode): separate notification cooldowns per session and fix Wind…
IamCoder18 ee543cb
fix(vscode): remove timestamp from shouldNotify key to restore cross-…
IamCoder18 1ed06cf
fix(i18n): add missing notification translations to all 18 locales
IamCoder18 45cd7c7
feat(vscode): add system notification sounds and bump eslint limits
IamCoder18 c7f4f7d
Merge branch 'main' into feat/issue-7048-system-notifications
IamCoder18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "kilo-code": minor | ||
| --- | ||
|
|
||
| Add OS-level system notifications with sound playback for agent events. When VS Code is not focused, users receive native desktop notifications (macOS Notification Center, Windows Toast, Linux notify-send) for agent task completion, permission requests, questions, and session errors. Includes 45+ configurable notification sounds and per-event enable/disable settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.