fix: handle chunked CLI startup port output in VS Code extension - #7650
fix: handle chunked CLI startup port output in VS Code extension#7650LuisCharro wants to merge 3 commits into
Conversation
| * Does NOT kill the server — that's the connection service's job. | ||
| */ | ||
| dispose(): void { | ||
| this.disposed = true |
There was a problem hiding this comment.
WARNING: dispose() can still leak connection listeners when initialization is mid-flight
If a tab/panel is closed while initializeConnection() is still awaiting this.connectionService.connect(...), dispose() runs before unsubscribeEvent / unsubscribeState have been assigned. The remainder of doInitializeConnection() will then register fresh listeners against KiloConnectionService, and there is no later cleanup path for this disposed provider. Add a this.disposed/this.webview guard after the awaited connection step before subscribing so closed webviews do not stay registered forever.
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (6 files)
Reviewed by gpt-5.4-20260305 · 731,627 tokens |
|
Closing as stale, as the review feedback was not addressed. Feel free to reopen or submit a follow-up PR with those changes. |
Fixes #7649
Summary
Testing
bunis unavailable here)