fix(vscode): stop config update loop from flooding SSE and killing server

[markijbema]

Summary

Two fixes for the settings panel flooding the server with events and killing it:

1. Stop Instance.disposeAll() from being called on every global config update. Previously, Config.updateGlobal() would nuke all running CLI instances (destroying session state, MCP connections, and in-flight operations across every project) whenever any global config changed. The global.reset() call already clears the config cache so consumers pick up the new config on their next read. The disposeAll() was unnecessary overkill.

2. Break infinite loop caused by Kobalte Select firing onChange on options list changes. Kobalte's Select has an internal createEffect that re-filters selected keys whenever flattenOptionKeys changes. When a global.disposed or server.instance.disposed SSE event arrives, the extension re-fetches config and pushes configLoaded to the webview. Solid creates new array references for the options, Kobalte detects the change, fires onChange with the same value, which calls updateConfig → PATCH /global/config → emits global.disposed → loop. With allowDuplicateSelectionEvents: true (Kobalte's default), this fires even when the value hasn't changed.

The loop

configLoaded → setConfig() → new options array ref
  → Kobalte Select internal effect fires onChange
  → onSelect → updateConfig({ default_agent: ... })
  → PATCH /global/config → Config.updateGlobal()
  → global.disposed event via SSE
  → reloadAfterAuthChange() → fetchAndSendConfig()
  → configLoaded → repeat ×N KiloProvider instances

Fix

• Remove Instance.disposeAll() from updateGlobal() (separate correctness fix — this was collateral damage on each loop iteration, not the cause)
• Guard all three settings Select onSelect handlers to skip updateConfig when the new value equals the current config value, breaking the loop

[kilo-code-bot]

WARNING: Existing instances keep using the old global config

global.reset() only invalidates the lazy result from Config.global(). Every open project still has its merged config cached in Config.state() via Instance.state(), so removing Instance.disposeAll() means active sessions keep stale modes, providers, and other global settings until that instance is explicitly disposed or the server restarts.

[marius-kilocode]

@markijbema true?

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File	Line	Issue
packages/opencode/src/config/config.ts	1561	Removing Instance.disposeAll() leaves each project's cached Config.state() stale after a global config change.

Other Observations (not in diff)

No additional issues found outside the diff.

Files Reviewed (4 files)

• packages/kilo-vscode/webview-ui/src/components/settings/AgentBehaviourTab.tsx - 0 issues
• packages/kilo-vscode/webview-ui/src/components/settings/DisplayTab.tsx - 0 issues
• packages/kilo-vscode/webview-ui/src/components/settings/ExperimentalTab.tsx - 0 issues
• packages/opencode/src/config/config.ts - 1 issue

---

_{Reviewed by gpt-5.4-20260305 · 491,849 tokens}