Skip to content

chore(kilo-vscode): fix prettier formatting on i18n files#6919

Merged
markijbema merged 1 commit into
mainfrom
chore/format-kilo-vscode
Mar 11, 2026
Merged

chore(kilo-vscode): fix prettier formatting on i18n files#6919
markijbema merged 1 commit into
mainfrom
chore/format-kilo-vscode

Conversation

@kilo-code-bot
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot Bot commented Mar 11, 2026

Summary

  • Runs prettier --write . in packages/kilo-vscode/ to fix 13 i18n translation files that had drifted out of Prettier compliance
  • No functional changes — purely whitespace/line-break formatting (long strings broken to respect printWidth: 120)

Context

PR #6911 included formatting corrections mixed in with feature changes. This PR extracts those formatting fixes so they can be landed independently, keeping feature PRs focused on actual code changes.

Files changed

All 13 files are in packages/kilo-vscode/webview-ui/src/i18n/ — the non-English translation files (ar, br, bs, da, de, es, fr, ja, ko, no, pl, ru, th). The English (en.ts), Chinese (zh.ts, zht.ts) files were already compliant.

How to prevent formatting drift going forward

cc @markijbema — here are recommendations to keep formatting in sync:

  1. Add format:check to CI — The packages/kilo-vscode/package.json already has a format:check script (prettier --check .), but no CI workflow runs it. Add a step to .github/workflows/test-vscode.yml (or create a new workflow) that runs bun run format:check in packages/kilo-vscode/. This is the single highest-impact change.

  2. Add a pre-commit hook with lint-staged — The repo already uses Husky (.husky/pre-push runs typecheck). Add a pre-commit hook that runs prettier --write on staged files via lint-staged. This catches formatting issues before they're even committed:

    // package.json (root)
    "lint-staged": {
      "packages/kilo-vscode/**/*.{ts,tsx,json,css}": "prettier --write"
    }
  3. Editor-level format-on-save — The repo has an .editorconfig but no .vscode/settings.json recommending format-on-save. Adding one would help contributors who use VS Code:

    {
      "editor.formatOnSave": true,
      "editor.defaultFormatter": "esbenp.prettier-vscode"
    }
  4. Run bun run format after i18n generation — The i18n files appear to be the primary source of drift (likely generated or bulk-edited by translation tooling). If there's a script or process that generates/updates these files, it should run prettier --write as a post-step.

The most impactful fix is #1 — a CI check that fails the build on formatting violations would have caught this before merge.

@kilo-code-bot
Copy link
Copy Markdown
Contributor Author

kilo-code-bot Bot commented Mar 11, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (13 files)
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts

Reviewed by gpt-5.4-20260305 · 1,347,382 tokens

@markijbema markijbema enabled auto-merge March 11, 2026 10:05
kilo-code-bot Bot added a commit that referenced this pull request Mar 11, 2026
Add a 'format:check' step to the test-vscode workflow so PRs that
introduce formatting drift in packages/kilo-vscode are caught before
merge. Uses the existing 'format:check' script (prettier --check .)
already defined in packages/kilo-vscode/package.json.

Ref: #6919
@markijbema markijbema merged commit 536d847 into main Mar 11, 2026
16 checks passed
@markijbema markijbema deleted the chore/format-kilo-vscode branch March 11, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant