chore(kilo-vscode): fix prettier formatting on i18n files#6919
Merged
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (13 files)
Reviewed by gpt-5.4-20260305 · 1,347,382 tokens |
markijbema
approved these changes
Mar 11, 2026
kilo-code-bot Bot
added a commit
that referenced
this pull request
Mar 11, 2026
Add a 'format:check' step to the test-vscode workflow so PRs that introduce formatting drift in packages/kilo-vscode are caught before merge. Uses the existing 'format:check' script (prettier --check .) already defined in packages/kilo-vscode/package.json. Ref: #6919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettier --write .inpackages/kilo-vscode/to fix 13 i18n translation files that had drifted out of Prettier complianceprintWidth: 120)Context
PR #6911 included formatting corrections mixed in with feature changes. This PR extracts those formatting fixes so they can be landed independently, keeping feature PRs focused on actual code changes.
Files changed
All 13 files are in
packages/kilo-vscode/webview-ui/src/i18n/— the non-English translation files (ar, br, bs, da, de, es, fr, ja, ko, no, pl, ru, th). The English (en.ts), Chinese (zh.ts,zht.ts) files were already compliant.How to prevent formatting drift going forward
cc @markijbema — here are recommendations to keep formatting in sync:
Add
format:checkto CI — Thepackages/kilo-vscode/package.jsonalready has aformat:checkscript (prettier --check .), but no CI workflow runs it. Add a step to.github/workflows/test-vscode.yml(or create a new workflow) that runsbun run format:checkinpackages/kilo-vscode/. This is the single highest-impact change.Add a pre-commit hook with lint-staged — The repo already uses Husky (
.husky/pre-pushruns typecheck). Add apre-commithook that runsprettier --writeon staged files vialint-staged. This catches formatting issues before they're even committed:Editor-level format-on-save — The repo has an
.editorconfigbut no.vscode/settings.jsonrecommending format-on-save. Adding one would help contributors who use VS Code:{ "editor.formatOnSave": true, "editor.defaultFormatter": "esbenp.prettier-vscode" }Run
bun run formatafter i18n generation — The i18n files appear to be the primary source of drift (likely generated or bulk-edited by translation tooling). If there's a script or process that generates/updates these files, it should runprettier --writeas a post-step.The most impactful fix is #1 — a CI check that fails the build on formatting violations would have caught this before merge.