fix(extension): allow killing detached processes

.changeset/kill-command-fix.md

@@ -0,0 +1,5 @@
+---
+"kilo-code": patch
+---
+
+Fix: "Kill Command" button now reliably terminates processes on all platforms, including those running in the background.

src/core/tools/ExecuteCommandTool.ts

@@ -308,14 +308,20 @@ export async function executeCommandInTerminal(
 				clearTimeout(timeoutId)
 			}
 
-			task.terminalProcess = undefined
+			// Don't clear if running in background - user may still want to kill it
+			if (!runInBackground) {
+				task.terminalProcess = undefined
+			}
 		}
 	} else {
 		// No timeout - just wait for the process to complete.
 		try {
 			await process
 		} finally {
-			task.terminalProcess = undefined
+			// Don't clear if running in background - user may still want to kill it
+			if (!runInBackground) {
+				task.terminalProcess = undefined
+			}
 		}
 	}
 

src/integrations/terminal/TerminalProcess.ts

@@ -257,10 +257,10 @@ export class TerminalProcess extends BaseTerminalProcess {
 	}
 
 	public override abort() {
-		if (this.isListening) {
-			// Send SIGINT using CTRL+C
-			this.terminal.terminal.sendText("\x03")
-		}
+		// User-initiated kill must always attempt to interrupt the process.
+		// Listening state does not reflect process liveness.
+		const terminal = this.terminalRef.deref()
+		terminal?.terminal?.sendText("\x03")
 	}
 
 	public override hasUnretrievedOutput(): boolean {

src/integrations/terminal/__tests__/TerminalProcess.spec.ts

@@ -30,6 +30,8 @@ describe("TerminalProcess", () => {
 	let mockStream: AsyncIterableIterator<string>
 
 	beforeEach(() => {
+		vi.clearAllMocks()
+
 		// Create properly typed mock terminal
 		mockTerminal = {
 			shellIntegration: {
@@ -186,6 +188,34 @@ describe("TerminalProcess", () => {
 		})
 	})
 
+	describe("abort", () => {
+		it("sends CTRL+C even after continue has been called", () => {
+			// Simulate user clicking "Proceed While Running"
+			terminalProcess.continue()
+
+			// User later clicks "Kill Command"
+			terminalProcess.abort()
+
+			// CTRL+C should still be sent to terminate the process
+			expect(mockTerminal.sendText).toHaveBeenCalledWith("\x03")
+			expect(mockTerminal.sendText).toHaveBeenCalledTimes(1)
+		})
+
+		it("sends CTRL+C when still listening", () => {
+			terminalProcess.abort()
+
+			expect(mockTerminal.sendText).toHaveBeenCalledWith("\x03")
+			expect(mockTerminal.sendText).toHaveBeenCalledTimes(1)
+		})
+
+		it("does not throw if terminal is already gone", () => {
+			// Simulate terminal being garbage collected
+			vi.spyOn(terminalProcess["terminalRef"], "deref").mockReturnValue(undefined)
+
+			expect(() => terminalProcess.abort()).not.toThrow()
+		})
+	})
+
 	describe("getUnretrievedOutput", () => {
 		it("returns and clears unretrieved output", () => {
 			terminalProcess["fullOutput"] = `\x1b]633;C\x07previous\nnew output\x1b]633;D\x07`